Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team gui #2251

Merged
merged 27 commits into from
Jan 8, 2024
Merged

Team gui #2251

merged 27 commits into from
Jan 8, 2024

Conversation

tastybento
Copy link
Member

@tastybento tastybento commented Dec 30, 2023

This adds GUI panels to enable team management. To start, run the team command. Also, the team invite command will also open a GUI. I have left the commands for team management as-is so that if players want to use them, they can.
The GUI doesn't require confirmation for kicking or changing owner, but it does require those "dangerous" commands to be SHIFT_LEFT or SHIFT_RIGHT clicks to prevent accidental selection.

@tastybento tastybento marked this pull request as ready for review January 4, 2024 12:57
@tastybento tastybento requested a review from BONNe January 4, 2024 13:01
1. added some lore to the invite button to explain the players shown are
from the game world
2. removed the team state in chat
3. added a search to the invite panel
@BONNe
Copy link
Member

BONNe commented Jan 5, 2024

Maybe ANVIL for player name input?

@tastybento
Copy link
Member Author

@BONNe I think this is pretty much done now. Please try the search feature and let me know what you think. If the name given doesn't match a player then it'll bounce back to the search GUI with a list of potential players with that text in their name.

Copy link

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

30 New issues
0 Security Hotspots
19.7% Coverage on New Code
0.9% Duplication on New Code

See analysis details on SonarCloud

@tastybento tastybento merged commit 0e0c502 into develop Jan 8, 2024
2 checks passed
@tastybento
Copy link
Member Author

I'm merging this but it can still be improved if required.

@tastybento tastybento deleted the team_gui branch January 21, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants