Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete slimefun chunks/blocks when island is deleted. #2247

Merged
merged 6 commits into from
Dec 24, 2023

Conversation

tastybento
Copy link
Member

This was a request of Discord.

This PR will tell the Slimefun plugin to delete blocks/chunks from its store when an island is deleted.

@tastybento tastybento requested a review from BONNe December 23, 2023 23:38
@tastybento tastybento added the Type: Enhancement Improvement or modification which is usually a new feature. label Dec 23, 2023
Individual blocks need to be destroyed because complete chunks may not
be used.
@tastybento tastybento marked this pull request as ready for review December 24, 2023 04:10
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

7.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@tastybento tastybento merged commit 86d8d14 into develop Dec 24, 2023
1 of 2 checks passed
@tastybento tastybento deleted the slimefun_hook branch December 24, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants