Bug fixes & CustomBlock type for mob spawning #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Everytime new phase was set, plugin sent the first block of the phase 2 times. - CustomBlocks in fixedBlocks were causing issues where it was pushing the CustomBlock multiple times into queue. - Phase config was not refreshed when doing /isa reload. I tested it and I do not see any issues. Refactors: - Variable naming refactors, because having name `obPhase` for `phase` instance + name `phase` for the `ConfigurationSection` was not really understandable (I changed it to `phaseConfig`) Added features: - New `CustomBlock` for mobs in format: ``` - type: mob mob: ZOMBIE underlying-block: GRASS_BLOCK ``` It will spawn a mob on top of underlying block. I know that mob spawns are not exactly counted as "destroyed block", but in this case it is needed. It would not make sense setting it in fixedBlocks if not.
- New `Requirement - cooldown` (seconds) that blocks new phase until time elapses.
HSGamer
reviewed
Nov 24, 2023
src/main/java/world/bentobox/aoneblock/oneblocks/customblock/MobCustomBlock.java
Outdated
Show resolved
Hide resolved
HSGamer
reviewed
Nov 24, 2023
src/main/java/world/bentobox/aoneblock/oneblocks/customblock/MobCustomBlock.java
Outdated
Show resolved
Hide resolved
…obCustomBlock.java Co-authored-by: Huynh Tien <[email protected]>
tastybento
approved these changes
Nov 24, 2023
|
Thanks @Baterka ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Refactors:
obPhaseforphaseinstance + namephasefor theConfigurationSectionwas not really understandable (I changed it tophaseConfig)Added features:
CustomBlockfor mobs in format:type: mob mob: ZOMBIE underlying-block: GRASS_BLOCKIt will spawn a mob on top of underlying block. I know that mob spawns are not exactly counted as "destroyed block", but in this case it is needed. It would not make sense setting it in fixedBlocks if not.Requirement - cooldown(seconds) that blocks new phase until time elapses.