Resolve shellcheck lint issues #100
Conversation
|
This refactor will require testing. Keeping in Draft for now. |
|
@BenWestgate please see my responses to your questions here and here on my fork. |
epiccurious
changed the title
|
Resolves #95. |
|
@BenWestgate To make it easier to do testing, can you please enable this setting at bottom of the main Settings page?
|
This refactor doesn't make a ton of sense so another option is to revert this commit and exclude SC2181.
epiccurious
force-pushed
the
95-resolve-shellcheck-lint-issues
branch
from
2303324 to
0391c05
Compare
|
Rebased. |
|
I'm seeing an issue with the PR during testing. Something is broken with the clone/download process. Will post a screen recording showing the failure. |
|
Here's the video recording for the failure: Here's the video recording for Bails master branch succeeding: PR isn't ready to merge yet unfortunately. |
It already is: |
So the download for the signatures threw an error, you can see that in the terminal and that's the Zenity message as well. Did you look up what that error meant? Did you try again starting fresh? It may have been a once off download failure, this PR does not touch the code that downloads the signatures so Master is the same. Which means this error is non-blocking unless you always got it. |
You were right. I re-ran it again on the same branch and it's downloading fine. That's the first time I've seen that intermittent failure. Perhaps a wget command that could use a retry=5 argument and/or better error handling. Setting PR as ready to review. Ready to merge. |
How would you suggest the error handling be improved? Just remove the option to try again? Since it already tried many times in order to fail there in the first place? |
* fix: exclude double-quoted variables rule * refactor: fix lint issues in persistent-setup * refactor: increase indentation of onlynet_onion * refactor: satisfy shellcheck SC2181 This refactor doesn't make a ton of sense so another option is to revert this commit and exclude SC2181. * refactor: fix indentation of link_dotfiles subshell * refactor: avoid for loops over find output [SC2044] * refactor: comment out unused variable * refactor: ensure variable never expands to /bin or /lib * refactor: use -n instead of ! -z * Ignore SC2046 in CI checks * fix syntax in yaml * refactor: read without -r will mangle backslashes * refactor: Declare and assign separately to avoid masking return values * refactor: read without -r will mangle backslashes * refactor: Don't use variables in the printf format string * refactor: $ is unnecessary on arithmetic variables * Remove the repeated ', providing ... privacy.' * Clarify that Bitcoin Core connects, not Bails * Make consistent with Lines 113 and 156 * Exclude SC2012 (Use 'cd ... || exit') and SC2164 (find instead of ls) * wording change in comment * lint fixes --------- Co-authored-by: Ben Westgate <[email protected]>
No description provided.