feat(handles): dns handles #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheButlah
force-pushed
the
thebutlah/dns-handles
branch
7 times, most recently
from
f3a1876 to
86da349
Compare
dooly123
approved these changes
Apr 5, 2025
| { | ||
| Local, | ||
| Dns, | ||
| // TODO: HttpWellKnown |
Collaborator
There was a problem hiding this comment.
we should make it so its
Local,
Dns,
Other,
this way developers can implement there own type without needing to modify this file.
Contributor
Author
There was a problem hiding this comment.
lets change later, I may delete this enum completely
TheButlah
force-pushed
the
thebutlah/dns-handles
branch
from
86da349 to
9219caa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #203 first
See the README.md files in the files changed for an explanation of how this is structured and what it does.
See Dns.Tests for the example usage.
I tried to make it so that
Handles(common folder) is a minimal library of just the interfaces and some necessary types, andDnsis a package that could live inContribwith a dependency onHandles. Once we start thinking about how to integrate this into the demo project, maybe we should putHandlesinto core, but keep dns, steam, etc in Contrib.But thats a dooly problem 😉