Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live testing fixes #91

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Live testing fixes #91

merged 6 commits into from
Dec 11, 2024

Conversation

md8n
Copy link

@md8n md8n commented Dec 11, 2024

Fixes I got from doing my own live testing.

Note that this specifically includes moving most of the 'socket' related code to a file called 'socket.js'.

BarbourSmith
BarbourSmith approved these changes Dec 11, 2024
View reviewed changes
Copy link
Owner

@BarbourSmith BarbourSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

www/js/SPIFFSdlg.js
@@ -256,9 +256,9 @@ function SPIFFSdispatchfilestatus(jsonresponse) {
}

setHTML("SPIFFS_file_list", content);
for (const action in actions) {
actions.forEach((action) => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BarbourSmith BarbourSmith merged commit fac7919 into BarbourSmith:Maslow-Main Dec 11, 2024
1 check passed
@BarbourSmith
Copy link
Owner

Unfortunately for me after merging this the UI is still failing to load with error:

Uncaught ReferenceError: can't access lexical declaration 'id' before initialization
    loadJogDists http://maslow.local/:63
    <anonymous> http://maslow.local/:63
[maslow.local:63:43991](http://maslow.local/)
Uncaught ReferenceError: can't access lexical declaration 'displayNone' before initialization
    onload http://maslow.local/:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BarbourSmith BarbourSmith BarbourSmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@md8n @BarbourSmith