forked from MitchBradley/ESP3D-WEBUI
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update app #90
Merged
Merged
Update app #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarbourSmith
approved these changes
Dec 12, 2024
These are great changes in theory, but I'm still not able to control the machine anymore with error messages:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fairly hefty PR
The focus is on reducing the size of
app.js
But that includes:
index.html
- some consolidation of embedded script, additional script inclusions, special reordering of script inclusions.connectdlg.js
- some minor cleanupgrbl.js
- moving theonReportType
event handler function out togrblpanel.js
- a new js file to handle the enormous volume of event handlers in the grbl panelgrblpanel.html
- removal of everyon*
attribute in the html, replaced withid
s and the above event handlerssocket.js
- a new js file for a lot of the socket handling code that was inapp.js
, and one that was inhttp.js
http.js
- moved out a function from here that wasn't a good fit.util.js
- moved one small function to here.preferencesdlg.js
- moved theontogglePing
function to here, where it is used.navbar.html
andnavbar.js
- similar to what was done for thegrblpanel
and finally
app.js
- with a massive clean out so that it is focussed on app startup and not much else.