Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app #90

Merged
merged 12 commits into from
Dec 12, 2024
Merged

Update app #90

merged 12 commits into from
Dec 12, 2024

Conversation

md8n
Copy link

@md8n md8n commented Dec 10, 2024

A fairly hefty PR

The focus is on reducing the size of app.js

But that includes:

  • index.html - some consolidation of embedded script, additional script inclusions, special reordering of script inclusions.
  • connectdlg.js - some minor cleanup
  • grbl.js - moving the onReportType event handler function out to
  • grblpanel.js - a new js file to handle the enormous volume of event handlers in the grbl panel
  • grblpanel.html - removal of every on* attribute in the html, replaced with ids and the above event handlers
  • socket.js - a new js file for a lot of the socket handling code that was in app.js, and one that was in http.js
  • http.js - moved out a function from here that wasn't a good fit.
  • util.js - moved one small function to here.
  • preferencesdlg.js - moved the ontogglePing function to here, where it is used.
  • navbar.html and navbar.js - similar to what was done for the grblpanel

and finally app.js - with a massive clean out so that it is focussed on app startup and not much else.

@md8n md8n marked this pull request as draft December 11, 2024 08:41
@md8n md8n marked this pull request as ready for review December 11, 2024 23:26
@md8n md8n marked this pull request as draft December 11, 2024 23:44
@md8n md8n marked this pull request as ready for review December 12, 2024 03:21
@BarbourSmith BarbourSmith merged commit a1a3394 into BarbourSmith:Maslow-Main Dec 12, 2024
1 check passed
@BarbourSmith
Copy link
Owner

These are great changes in theory, but I'm still not able to control the machine anymore with error messages:

Uncaught ReferenceError: can't access lexical declaration 'id' before initialization
    loadJogDists http://maslow.local/:63
    <anonymous> http://maslow.local/:63
[maslow.local:63:44039](http://maslow.local/)
Uncaught ReferenceError: can't access lexical declaration 'displayNone' before initialization
    onload http://maslow.local/:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants