Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Confirm Dialog #68

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Update the Confirm Dialog #68

merged 1 commit into from
Dec 5, 2024

Conversation

md8n
Copy link

@md8n md8n commented Dec 5, 2024

Update the confirm dialog, used in several places.

BarbourSmith
BarbourSmith approved these changes Dec 5, 2024
View reviewed changes
Copy link
Owner

@BarbourSmith BarbourSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 👍 👍

@BarbourSmith BarbourSmith merged commit 25b5bfa into BarbourSmith:Maslow-Main Dec 5, 2024
1 check passed
@BarbourSmith
Copy link
Owner

BarbourSmith commented Dec 5, 2024 •
edited
Loading

Oops I shoulda tested before merging 😬

I'm getting Uncaught SyntaxError: import declarations may only appear at top level of a module which bricks the UI

@md8n
Copy link
Author

md8n commented Dec 5, 2024

Oops I shoulda tested before merging 😬

I'm getting Uncaught SyntaxError: import declarations may only appear at top level of a module which bricks the UI

yeah- I forgot to remove the import/export - now done.

@BarbourSmith
Copy link
Owner

I think you have to make a new PR for me to be able to bring in the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BarbourSmith BarbourSmith BarbourSmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@md8n @BarbourSmith