Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the alertdlg to not use on* event handlers #65

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Update the alertdlg to not use on* event handlers #65

merged 1 commit into from
Dec 4, 2024

Conversation

md8n
Copy link

@md8n md8n commented Dec 4, 2024

Update the HTML to not use on*. Instead, proper eventhandlers are added in the js code

@BarbourSmith
Copy link
Owner

Looks good to me, I'm totally on board with the use of arrow functions.

This won't change the use of gulp yet, right?

BarbourSmith
BarbourSmith approved these changes Dec 4, 2024
View reviewed changes
Copy link
Owner

@BarbourSmith BarbourSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An excellent step into the 21st century 😀

@BarbourSmith BarbourSmith merged commit 8ea2c00 into BarbourSmith:Maslow-Main Dec 4, 2024
1 check passed
@md8n md8n deleted the update_alertdlg branch December 5, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BarbourSmith BarbourSmith BarbourSmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@md8n @BarbourSmith