Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard time #35

Closed
wants to merge 17 commits into from
Closed

Conversation

ronlawrence3
Copy link

@ronlawrence3 ronlawrence3 commented Jun 1, 2024

@BarbourSmith

I'll publish an index.html.gz for people to try and if it is well received we can merge it or change it based on feedback. It creates a wizard for setting up the maslow in another tab. The tab is activated if the maslow is not homed, but you can navigate to / from it also.

image
image
image
image
image
image

also:
image

@BarbourSmith
Copy link
Owner

This looks fantastic! I love the idea. I’m moving today so I’m going to be away from my machine, but I will play around with it first thing tomorrow

www/js/tablet.js Outdated
};

msg += msgExtra[msg.split(":")[1]] || "";
let parts = msg.split(":");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we might have the issue where some of these changes are undoing changes on the main branch. @md8n cleaned up some of this code here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have another look at my diffs and resolve this. I just noticed the merge I did had issues when I ran it so likely I just resolved things wrong.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That always gets tricky

@ronlawrence3
Copy link
Author

More testing needed... I'll see if I can run this through a couple cycles in the next few days...

@ronlawrence3
Copy link
Author

Also today I decided to give this a spin outside the python proxy by uploading, and it won't fit on the filesystem, so I will have more to do to slim it down some.

@ronlawrence3
Copy link
Author

OK, I think this is in good shape now and worth a try. Feedback welcome!

@ronlawrence3 ronlawrence3 marked this pull request as ready for review June 8, 2024 13:53
@ronlawrence3
Copy link
Author

oops, forgot to @BarbourSmith notify I'm ready :) also no rush... just want to make sure you know its ready to look at

@BarbourSmith
Copy link
Owner

I haven't forgotten. I think that this one will take a decent amount of time to test and I want to track down this crashing bug first, but I won't forget!

@ronlawrence3
Copy link
Author

I totally understand and fully agree with your priorities! I did a bit more polishing of the code today. it is still behaving pretty well.

@BarbourSmith
Copy link
Owner

I'm finally having a second to really dig into this and I think I have a plan.

The goal of wizard is to guide the user through the calibration process, but I think that what we really need to do is make the process simpler to the point that we don't need a wizard.

I have a plan that I'd like to work towards which would be to have just two buttons one for "Extend Belts" and one for "Retract Belts".

The extend belts just extends the belts as long as you are pulling on them. We don't ask the user the size of their frame, we just let them extend enough to attach to the frame.

The retract belts pulls the belts tight. When the belts get tight we can check to see if everything looks good with calibration. If the belt lengths match what we would expect from the stored calibration then we're good, if they don't match up then we can ask the user if they want to run calibration.

This would also let us store the belt lengths and re-use them without needing to do the whole Retract -> Extend cycle and not worry about breaking the belts because the first thing that the retract button does is pull the belts tight and check that everything is OK which would catch cases where the belts had moved while the machine was off.

Does that seem like a reasonable alternative?

@ronlawrence3
Copy link
Author

Does that seem like a reasonable alternative?

Absolutely! I'm lukewarm on my implementation of the wizard anyway after living with it a while, and the forums have calmed down a lot in terms of calibration confusion, so this is probably not needed any more.

I have other thoughts too, such as once the machine is on the frame, detecting horizontal or vertical, detecting what threshold to set, etc.

@BarbourSmith
Copy link
Owner

I have other thoughts too, such as once the machine is on the frame, detecting horizontal or vertical, detecting what threshold to set, etc.

These sound like fantastic ideas. Detecting horizontal or vertical is top of my list for things that I think we need.

What do you mean by detecting the threshold? How would that work?

@ronlawrence3
Copy link
Author

What do you mean by detecting the threshold? How would that work?

This is just my naive thinking probably, but when first assembled, the retract (for me at least) had to be increased until it would retract fully. I've seen others report this as well. I assume it is however tight the arms are, etc.

I was thinking an initial step after assembly could be retract-all at something like 2500, then extend out maybe 100mm on each arm and have the maslow start low and retract each for a time and then stop and check if it did retract, then repeat until meeting the threshold. Not sure this would work, but that is what I was thinking.

@BarbourSmith
Copy link
Owner

I love that idea. I think that would work perfectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants