Remove the restart prompt when saving settings to maslow.yaml file #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, absolutely! I think we could also just have a popup that says "if you changed your anchor points, be sure to restart" which I think would be when you'd want to, right? |
|
Actually I don't think that you need to restart even if you change your anchor points! It's only the real FluidNC stuff like if you change your stepper driver settings that requires a restart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the fluidNC settings require a restart to take effect, the maslow settings for calibration actually don't, they can be applied right away. Since 99% of what folks are going to be changing in their settings is going to be calibration related I don't think we should encourage the restart because they they have to do the whole retract - extend thing again which we want to eliminate.
@ronlawrence3 Are you OK with this?