Add a save to config items panel #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BarbourSmith Here is the PR for a save button. I think I can pretty easily add "help" tooltip icons to each maslow item without adding too much overhead. I'll see if I can get to that "soon" |
|
This looks AMAZING!! Absolutely brilliant work. I will test and merge today. This is going to save so many people so much headache with extra spaces breaking their files etc. HUGE. |
BarbourSmith
approved these changes
Mar 30, 2024
| @@ -208,10 +208,20 @@ function build_control_from_pos(pos, extra) { | |||
| return build_control_from_index(get_index_from_eeprom_pos(pos), extra) | |||
| } | |||
|
|
|||
| function saveMaslowYaml() { | |||
| SendGetHttp('/command?plain=' + encodeURIComponent("$CD=/maslow.yaml")); | |||
| restart_esp(); | |||
There was a problem hiding this comment.
Do we even need to restart? Since the settings are already on the machine and also in the .yaml file I'm not sure we need to do a restart
BarbourSmith
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some help and a save button to save to maslow.yaml and restart the esp32.