Merged
Conversation
gerard-morera
commented
Jun 23, 2020
| end | ||
|
|
||
| def acknowleged? | ||
| !!result |
Author
There was a problem hiding this comment.
FYI result when comes is an empty string.
oricodes89
reviewed
Jun 23, 2020
oricodes89
reviewed
Jun 23, 2020
oricodes89
approved these changes
Jun 23, 2020
Member
oricodes89
left a comment
oricodes89
left a comment
There was a problem hiding this comment.
LGTM, the gem handles responses in a confusing way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 References
🎯 What is the goal?
Perform server purchases acknowledgement.
Purchases ACK is used to confirm to google play that the purchase flow happened as expected. If the ACK does not happen the purchase is refunded within 4 minutes.
If the ACK is done from the client-side and the validation to the server fails it will make users that have paid not having it's correspondent capabilities active. This candy_check new feature will let acknowledge the purchase after capabilities grant.
📝 How is it being implemented?
Following Candy Check patterns and calling to Google API ACK service.