Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server ACK for consumable #1

Merged
merged 4 commits into from
Jun 23, 2020

Conversation

gerard-morera
Copy link

📌 References

  • Issue: Fixes Candy Check Issue

🎯 What is the goal?

Perform server purchases acknowledgement.

Purchases ACK is used to confirm to google play that the purchase flow happened as expected. If the ACK does not happen the purchase is refunded within 4 minutes.

If the ACK is done from the client-side and the validation to the server fails it will make users that have paid not having it's correspondent capabilities active. This candy_check new feature will let acknowledge the purchase after capabilities grant.

📝 How is it being implemented?

Following Candy Check patterns and calling to Google API ACK service.

end

def acknowleged?
!!result
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI result when comes is an empty string.

Copy link
Member

@oricodes89 oricodes89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the gem handles responses in a confusing way.

@gerard-morera gerard-morera merged commit aa11dbe into master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants