Fix buffer reuse issue in WebSockets #1532
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses issue [#1527] by modifying the way buffers are managed in PodeSignalRequest. The problem was that the base class, PodeRequest, uses a readonly, preallocated buffer that cannot be reinitialized. This caused issues for WebSocket signals (handled by PodeSignalRequest) where a fresh buffer is needed per Receive call.
Changes Introduced:
Lazy Buffer Initialization in PodeRequest:
GetBuffer()that returns the buffer. By default, it returns the lazily initialized, single preallocated buffer:Override in PodeSignalRequest:
GetBuffer()to return a new byte array for each Receive call:This ensures that every WebSocket signal request gets a fresh buffer, avoiding any leftover data from previous operations.
Integration Test:
Impact:
Testing: