web: parse gd version number correctly #5868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were checking specifically for '2.0'. If you had a later version (like 2.2) it would think you had an old version, and use an old image conversion function that produces wrong-colored results.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5868 +/- ##
============================================
+ Coverage 10.53% 10.75% +0.21%
Complexity 1068 1068
============================================
Files 279 280 +1
Lines 35875 36552 +677
Branches 8412 8471 +59
============================================
+ Hits 3780 3930 +150
- Misses 31701 32233 +532
+ Partials 394 389 -5 |
AenBleidd
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were checking specifically for '2.0'.
If you had a later version (like 2.2) it would think you had an old version, and use an old image conversion function that produces wrong-colored results.