Skip to content

Commit

Permalink
moved zones to required attribute. (#17)
Browse files Browse the repository at this point in the history
* moved zones to required attribute

* defaulting zones
  • Loading branch information
cshea-msft authored Mar 15, 2024
1 parent 5b9787c commit 81b9842
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 8 deletions.
12 changes: 10 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -224,11 +224,19 @@ Default: `null`

### <a name="input_firewall_zones"></a> [firewall\_zones](#input\_firewall\_zones)

Description: (Optional) Specifies a list of Availability Zones in which this Azure Firewall should be located. Changing this forces a new Azure Firewall to be created.
Description: (Required) Specifies a list of Availability Zones in which this Azure Firewall should be located. Changing this forces a new Azure Firewall to be created.

Type: `set(string)`

Default: `null`
Default:

```json
[
"1",
"2",
"3"
]
```

### <a name="input_lock"></a> [lock](#input\_lock)

Expand Down
1 change: 1 addition & 0 deletions examples/multi-addresses/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ resource "azurerm_public_ip" "public_ip" {
allocation_method = "Static"
sku = "Standard"
public_ip_prefix_id = azurerm_public_ip_prefix.public_ip_prefix.id
zones = ["1", "2", "3"]
}
# This is the module call
Expand Down
1 change: 1 addition & 0 deletions examples/multi-addresses/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ resource "azurerm_public_ip" "public_ip" {
allocation_method = "Static"
sku = "Standard"
public_ip_prefix_id = azurerm_public_ip_prefix.public_ip_prefix.id
zones = ["1", "2", "3"]
}

# This is the module call
Expand Down
12 changes: 6 additions & 6 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@ variable "firewall_sku_tier" {
nullable = false
}

variable "firewall_zones" {
type = set(string)
default = ["1", "2", "3"]
description = "(Required) Specifies a list of Availability Zones in which this Azure Firewall should be located. Changing this forces a new Azure Firewall to be created."
}

variable "firewall_dns_servers" {
type = list(string)
default = null
Expand Down Expand Up @@ -113,12 +119,6 @@ variable "firewall_virtual_hub" {
EOT
}

variable "firewall_zones" {
type = set(string)
default = null
description = "(Optional) Specifies a list of Availability Zones in which this Azure Firewall should be located. Changing this forces a new Azure Firewall to be created."
}

variable "lock" {
type = object({
name = optional(string, null)
Expand Down

0 comments on commit 81b9842

Please sign in to comment.