Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Twitter/X Custom Auth Support #889

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Conversation

Timothyw0
Copy link
Member

@Timothyw0 Timothyw0 commented Sep 26, 2024

Description

New feature: Adding Twitter/X custom auth support using Twitter's manual OAuthv2 token flow.
Some quirks of Twitter's flow:

  • It is not an OIDC flow so the returned information does not encompass as much as other providers
  • Different properties of client id and secret in staticwebappconfig.json schema

Additional Fix

Chore: Updated actions/upload-artifact version since v2 is now deprecated
image

Testing

Twitter staticwebappconfig.json:
image

Twitter /.auth/me:
image

Regression Testing below

AAD/Entra ID /.auth/me:
image

Google /.auth/me:
image

Facebook /.auth/me:
image

Github /.auth/me:
image

@github-actions github-actions bot added scope: core Issues happened a the ./src/core level scope: auth Issues related to the authentication emulator labels Sep 26, 2024
@Timothyw0 Timothyw0 marked this pull request as ready for review September 26, 2024 15:42
@Timothyw0 Timothyw0 merged commit 6745391 into Azure:main Oct 14, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: auth Issues related to the authentication emulator scope: core Issues happened a the ./src/core level
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants