Skip to content

Conversation

@marvinbuss
Copy link
Collaborator

Summary of the Pull Request

  • Fully switched to Bicep deployments
  • Added deployment names
  • Trigger on main only
  • Changed what-if step in GH workflow
  • Updated links to code of conduct

References

PR Checklist

Validation Steps Performed

See automated checks below.

@marvinbuss marvinbuss added feature Feature Requests committed Committed item labels Feb 2, 2022
@marvinbuss marvinbuss added this to the v1.3.0 milestone Feb 2, 2022
@marvinbuss marvinbuss self-assigned this Feb 2, 2022
@marvinbuss marvinbuss requested a review from a team as a code owner February 2, 2022 12:55
@marvinbuss marvinbuss linked an issue Feb 2, 2022 that may be closed by this pull request
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Waiting for microsoft/azure-pipelines-tasks#15337 to confirm release.

@mike-leuer
Copy link
Contributor

I have changed my template to use AZURE CLI, I probably will be making a PR once I finish splitting it up for DEV,TEST,PROD
https://docs.microsoft.com/en-us/azure/azure-resource-manager/bicep/add-template-to-azure-pipelines?tabs=CLI

Just doing some testing and making sure I like the new design I am using.

- task: AzureCLI@2
  inputs:
    azureSubscription: $(azureServiceConnection)
    scriptType: bash
    scriptLocation: inlineScript
    inlineScript: |
      az account set `
        --subscription ${{ parameters.AZURE_SUBSCRIPTION_ID }}
      az deployment sub `
        --location ${{ parameters.AZURE_LOCATION }} `
        --subscription ${{ parameters.AZURE_SUBSCRIPTION_ID }} `
        --template-file "$(System.DefaultWorkingDirectory)/infra/main.bicep" `
        --parameters "$(System.DefaultWorkingDirectory)/infra/params.${{ parameters.environment }}.json" 

@vanwinkelseppe
Copy link
Contributor

@marvinbuss any idea when this workflow is getting merged in main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

committed Committed item feature Feature Requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fully move to bicep

4 participants