Fix typing in samples #38354
Open
Fix typing in samples #38354
+92
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick863
requested review from
luigiw,
needuv,
achauhan-scc,
kingernupur,
paulshealy1 and
singankit
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
jhakulin
reviewed
Nov 6, 2024
sdk/ai/azure-ai-projects/samples/agents/sample_agents_with_file_search_attachment.py
Outdated
Show resolved
Hide resolved
jhakulin
reviewed
Nov 6, 2024
sdk/ai/azure-ai-projects/samples/connections/async_samples/sample_connections_async.py
Outdated
Show resolved
Hide resolved
jhakulin
reviewed
Nov 6, 2024
sdk/ai/azure-ai-projects/samples/agents/sample_agents_functions.py
Outdated
Show resolved
Hide resolved
jhakulin
approved these changes
Nov 6, 2024
jhakulin
approved these changes
Nov 7, 2024
dargilco
approved these changes
Nov 7, 2024
dargilco
reviewed
Nov 8, 2024
| @@ -121,22 +123,22 @@ async def sample_connections_async(): | |||
| print("====> Creating ChatCompletionsClient using API key authentication") | |||
| from azure.core.credentials import AzureKeyCredential | |||
|
|
|||
| client = ChatCompletionsClient( | |||
| endpoint=connection.endpoint_url, credential=AzureKeyCredential(connection.key) | |||
| ai_client = ChatCompletionsClient( | |||
There was a problem hiding this comment.
In the sync sample version you call it inference_client. So if you want to change the name, you can change it to that.
There was a problem hiding this comment.
Mypy defines the variable type y its first occurrence in the code and once it was assigned specific type, it will complain if we call methods of the other type.
dargilco
reviewed
Nov 8, 2024
|
|
||
| import os | ||
| from azure.ai.projects import AIProjectClient | ||
| from azure.ai.projects.models import ConnectionType, AuthenticationType | ||
| from azure.identity import DefaultAzureCredential | ||
|
|
||
| #from azure.identity import DefaultAzureCredential, get_bearer_token_provider | ||
| from azure.core.credentials import TokenCredential |
There was a problem hiding this comment.
Please put this import statement above the line that uses it.
dargilco
reviewed
Nov 8, 2024
|
|
||
| import asyncio | ||
| import os | ||
| from azure.ai.projects.aio import AIProjectClient | ||
| from azure.ai.projects.models import ConnectionType, AuthenticationType | ||
| from azure.core.credentials_async import AsyncTokenCredential | ||
| from azure.identity.aio import DefaultAzureCredential |
There was a problem hiding this comment.
Please put the line from azure.core.credentials_async import AsyncTokenCredential above the line that uses it, not at the top.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines