Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type case issues in KeyRotationPolicyActionType for armkeyvault package. #23928

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nir-mo
Copy link

@nir-mo nir-mo commented Jan 9, 2025

Purpose

This PR fixes type case issues in the KeyRotationPolicyActionType constant values within the armkeyvault package.

Background

When using the armkeyvault package to fetch Key Vault key rotation policy details, the type case mismatch in KeyRotationPolicyActionType constants causes parsing issues with the Azure API response. The API returns lowercase values while the SDK expects title case.

Changes

  • Updated KeyRotationPolicyActionType constant values to match the API response format
  • Modified the case from title case (e.g., "Rotate", "Notify") to lowercase (e.g., "rotate", "notify")

Impact

This is a breaking change for any code explicitly referencing the KeyRotationPolicyActionType constants, but necessary to maintain compatibility with the Azure API responses.

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to module CHANGELOG.md are included.
  • MIT license headers are included in each file.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. labels Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

Thank you for your contribution @nir-mo! We will review the pull request and get back to you soon.

@tadelesh
Copy link
Member

@nir-mo thanks for your contribution. however, our sdk is auto generated from spec file: https://github.com/Azure/azure-rest-api-specs/blob/b6075dbc2321933382ea91c787ee62c6bdb87e5d/specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2023-07-01/keys.json#L617-L623. could you open an issue in azure-rest-api-specs repo and let corresponding service team to fix the spec first?

@nir-mo
Copy link
Author

nir-mo commented Jan 12, 2025

Refere

@tadelesh I opened an addition PR under azure-rest-api-specs: Azure/azure-rest-api-specs#32107

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants