Azcore separate tracer #23715
Open
Azcore separate tracer #23715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to allow azcore consumers to indicate the azcore tracer should be named after the azcore module instead of the consumer's module
kjg
requested review from
RickWinter,
chlowell,
jhendrixMSFT and
richardpark-msft
as code owners
github-actions
bot
added
Azure.Core
Community Contribution
|
Thank you for your contribution @kjg! We will review the pull request and get back to you soon. |
|
I'm not sure how to make the dependency check pass since I can't update tracing/azotel version of azcore and account for the breaking change until the change is merged and a new version released. Any guidance on how to approach that? |
|
Hi @kjg. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
github-actions
bot
added
the
no-recent-activity
|
I'd love to keep working on this if I can get some guidance. Thanks! |
github-actions
bot
removed
the
no-recent-activity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes [Tracing] Allow Client libraries to configure schema URL #23307
This PR allows a schemaURL to be passed to the NewTracer function so that consumers can create tracers that use a different schemaURL than azcore.
It updates azcore to use the otel semconv package that sets a schemaURL and then uses the semconv Constances for the span keys that have defined semconv keys.
This PR also adds a
WithCoreTracerNamefunction to the azcore client so the consumers that do want to do custom tracing can make azcore using azcore's module name and version for the HTTP tracing, and their own module name and version for their portion of the tracing. UsingWithCoreTracerNameonly changes the values used for tracing to azcore values, it still leaves the passed in module name and version for use with the HTTP User Agent header.I chose this approach because it looks like many of the consumers of this client