Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FinOps toolkit 0.7 - optimization-workbook update #14231

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

flanakin
Copy link
Member

@flanakin flanakin commented Dec 1, 2024

PR Checklist

Check these items before submitting a PR...

Contribution Guide

Best Practice Guide

  • - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.

Changelog

  1. On the Storage tab, included the RSVaultBackup tag in the list of non-idle disks.
  2. On the Commitment discounts tab, fixed RI ROWS Limited.
  3. On the Compute tab, fixed incorrect VM processor in processors query.
  4. On the Database tab, removed the idle SQL databases query.

@flanakin
Copy link
Member Author

flanakin commented Dec 1, 2024

Failure is due to a false positive error and should be ignored

@alex-frankel
Copy link
Contributor

@flanakin - what does false positive mean in this context? Is there something in the CI environment that is causing the deployment to fail that won't happen in a customer environment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants