Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow task sets in df.task.all and df.task.any #174

Open
wants to merge 1 commit into
base: AllowTaskSetsInAllOrAny
Choose a base branch
from
Open

Allow task sets in df.task.all and df.task.any #174

wants to merge 1 commit into from
+3 −3

Conversation

CharlesGuillot
Copy link

Allow task sets in df.task.all and df.task.any typing

@CharlesGuillot
Allow task sets in df.task.all and df.task.any
205aa76 
Allow task sets in df.task.all and df.task.any typing
@davidmrdavid davidmrdavid self-requested a review April 21, 2020 00:07
@davidmrdavid davidmrdavid mentioned this pull request Apr 21, 2020
Closed
@davidmrdavid
Copy link
Collaborator

Hi @CharlesGuillot! Thank you for your contribution!! ⚡ ⚡

We're taking a close look at your PR, as we're trying to unify TaskSet and Task under the same identifier. In the future, we may remove TaskSet as a distinguishing identifier from Task so we still have to discuss whether or not this exact PR is something we'll want to merge, but we're driving a fix forward that will address this and a handful of other scenarios.

You can follow our discussion here: #185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmrdavid davidmrdavid Awaiting requested review from davidmrdavid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CharlesGuillot @davidmrdavid