-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prejit support on FunctionsNetHost #2711
base: main
Are you sure you want to change the base?
Conversation
@steveisok @ivdiazsa FYI. |
@khkh-ms FYI. I used a previously generated trace for this PR. Once your changes are done, we could replace this file with that. Let's merge both traces to single file (like what we do for host) |
…t package. Minor version bumped.
@steveisok @ivdiazsa Appreciate if you could do review the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you added unit tests where possible?
I don't have further comments other than addressing the ones that have been pointed out so far. |
…ONS_NETHOST" for env variables.
We don't have any tests as of today as what we want to validate is the native output. There has been discussion about adding an E2E test which simulates the linux scenarios as part of build pipeline (potentially a nightly build). Never got a chance to create a work item until now. #2724 I think that should be the priority. We can certainly revisit as we have more cycles to work on this. |
Looks good to me! Glad you were able to work this in 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #2637
This PR adds support for pre-jitting framework methods during placeholder mode. Currently this is enabled only for net8 onwards. This behavior can be explicitly disabled by setting
AZURE_FUNCTIONS_FUNCTIONSNETHOST_DISABLE_PREJIT
environment variable value to0
.See internal wiki page for more context.
I will have a separate follow up PR for fixing the build pipeline & nuget packaging needed for this change.Also included the build pipeline changes to include the new artifacts in the final package.Did a minor version bump.
Pull request checklist
release_notes.md