Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyzer for Multiple-Output Binding Scenarios with ASP.NET Core Integration #2706

Merged
merged 11 commits into from
Oct 16, 2024
Merged

Analyzer for Multiple-Output Binding Scenarios with ASP.NET Core Integration #2706

merged 11 commits into from
Oct 16, 2024

Conversation

satvu
Copy link
Member

@satvu satvu commented Sep 12, 2024 •
edited
Loading

Issue describing the changes in this PR

resolves #2352

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional Information

Screenshots of the alert and code-fix.

alert code-fix

@liliankasem
Copy link
Member

Can you include a screenshot/gif in the PR desc of this analyzer working?

liliankasem
liliankasem reviewed Sep 16, 2024
View reviewed changes
docs/analyzer-rules/AZFW0015.md Show resolved Hide resolved
...ons/Worker.Extensions.Http.AspNetCore.Analyzers/src/CodeFixForHttpResultAttributeExpected.cs Outdated Show resolved Hide resolved
...ons/Worker.Extensions.Http.AspNetCore.Analyzers/src/CodeFixForHttpResultAttributeExpected.cs Show resolved Hide resolved
...ons/Worker.Extensions.Http.AspNetCore.Analyzers/src/CodeFixForHttpResultAttributeExpected.cs Outdated Show resolved Hide resolved
extensions/Worker.Extensions.Http.AspNetCore.Analyzers/src/DiagnosticDescriptors.cs Outdated Show resolved Hide resolved
extensions/Worker.Extensions.Http.AspNetCore.Analyzers/src/ITypeSymbolExtensions.cs Show resolved Hide resolved
extensions/Worker.Extensions.Http.AspNetCore.Analyzers/src/ITypeSymbolExtensions.cs Show resolved Hide resolved
@satvu satvu force-pushed the satvu/http-multi-output-analyzer branch from a93228a to 5528588 Compare October 16, 2024 18:56
@satvu satvu merged commit 7b1bd29 into main Oct 16, 2024
31 checks passed
@satvu satvu deleted the satvu/http-multi-output-analyzer branch October 16, 2024 19:38
jviau added a commit that referenced this pull request Oct 23, 2024
@jviau @surgupta-msft
@liliankasem @fabiocav @satvu @dependabot @brettsam @SimonCropp @Y-Sindo @RohitRanjanMS @DL444 @vanillajonathan
Prep Extensions.Rpc release: merge main into release/main (#2805)
6eb8998 
* Generators package version update (#2755)

* Generator tests: Add transitive dependency for System.Text.Json v8.0.5 & bump extension versions (#2760)

* Fixing Function Executor test

* Refactor WebJobs extension info  (#2762)

* skipBuildTagsForGitHubPullRequests when the PR is a fork (#2770)

* Bump System.Text.Json from 8.0.4 to 8.0.5 in /host/src/FunctionsNetHost (#2768)

Bumps [System.Text.Json](https://github.com/dotnet/runtime) from 8.0.4 to 8.0.5.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.4...v8.0.5)

---
updated-dependencies:
- dependency-name: System.Text.Json
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* re-use FunctionsWorkerApplicationBuilder if called multiple times (#2774)

* Add worker extension validation to CI (#2764)

* ignore rider temp files

* Support SignalR trigger return value (#2771)

* add skipBuildTagsForGitHubPullRequests for extensions (#2779)

* Fix typos in CI referencing test projects (#2773)

* Adding a null check before initiating the internal Activity (#2765)

* Adding a null check for the internal Activity.

* Bump System.Text.Json to 8.0.5 (#2783)

* Use full namespace for Task.FromResult in function metadata provider generator to avoid namespace conflict (#2681)

* Analyzer for Multiple-Output Binding Scenarios with ASP.NET Core Integration (#2706)

* Remove documentation tag (#2751)

The parameter does not exist.

* Update global.json .net8 value (#2795)

* initial fix of duplicate registrations if AddFunctionsWorkerCore called twice (#2790)

* Ignoring fatal exceptions in InvocationHandler (#2789)

* Update nethost global json, update sample (#2797)

* Set extension RPC max message length (#2772)

* Set max message length for RPC client

* Update Rpc version and release notes

* Update packages (#2800)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Surbhi Gupta <[email protected]>
Co-authored-by: Lilian Kasem <[email protected]>
Co-authored-by: Fabio Cavalcante <[email protected]>
Co-authored-by: sarah <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brett Samblanet <[email protected]>
Co-authored-by: Simon Cropp <[email protected]>
Co-authored-by: yzt <[email protected]>
Co-authored-by: Rohit Ranjan <[email protected]>
Co-authored-by: David Lee <[email protected]>
Co-authored-by: Jonathan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liliankasem liliankasem liliankasem approved these changes

@fabiocav fabiocav Awaiting requested review from fabiocav

@surgupta-msft surgupta-msft Awaiting requested review from surgupta-msft

@kshyju kshyju Awaiting requested review from kshyju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Analyzer for multiple output bindings using IActionResult
3 participants
@satvu @liliankasem @kshyju