Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuction App Flex Consumption publish support #2688

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

anvillan
Copy link

@anvillan anvillan commented Sep 6, 2024

Issue describing the changes in this PR

resolves (TBD)

In this PR:

  • Add new UseBlobContainerDeploy (bool) property to the ZipDeploy target/task to identify when to use the
    "<publishUrl>/api/publish" endpoint to publish a Flex Consumption function app
  • When polling for the ZipDeploy pubish status, append the status_text message (if defined) along with the status itself. E.g.: "Deployment status is Failed: App setting WEBSITE_RUN_FROM_PACKAGE is not supported...".

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@nzthiago
Copy link
Member

nzthiago commented Sep 6, 2024

@patelchandni @fabiocav - this PR is from the Visual Studio team to add publish support for Flex Consumption for the .NET Isolated worker. Please review.

Copy link
Member

@fabiocav fabiocav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anvillan can you please add a note covering those changes to sdk/release_notes.md?

Thanks!

Copy link

@patelchandni patelchandni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested few changes based on new API behavior. Rest looks good, thank you.

sdk/Sdk/Tasks/ZipDeploy/ZipDeployTask.cs Outdated Show resolved Hide resolved
anvillan and others added 2 commits September 9, 2024 09:38
…ation; set correct query params to URLs; add UTs for ZipDeployTask and ZipDeploymentStatus
@anvillan
Copy link
Author

anvillan commented Sep 9, 2024

@patelchandni

I added UTs for ZipDeploy task and ZipDeploymentStatus. They are a copy of what it is already in azure_functions_vs_build_sdk repo. Here: https://github.com/anvillan/azure-functions-vs-build-sdk/tree/main/test/Microsoft.NET.Sdk.Functions.MSBuild.Tests

I also added the new cases for the new variations after the changes introduced in this PR.

Copy link

@patelchandni patelchandni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

@anvillan
Copy link
Author

@fabiocav, could you please take a look and help me to complete all the checks so this PR merges?

I can't see any actionable items for me to do.

CC: @nzthiago, @patelchandni

@fabiocav
Copy link
Member

/azp run dotnet-worker.public

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants