-
Notifications
You must be signed in to change notification settings - Fork 3.3k
{Packaging} Bump websocket-client to avoid pkg_resources references
#32791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{Packaging} Bump websocket-client to avoid pkg_resources references
#32791
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
necusjz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR bumps the websocket-client dependency from version 1.3.1 to 1.8.0 to avoid pkg_resources references, aligning with Python's move toward importlib.metadata. The websocket-client library is used in Azure CLI for WebSocket connections in container exec and SSH functionality (appservice tunnel, container exec, and containerapp SSH).
Changes:
- Updated websocket-client dependency from 1.3.1 to 1.8.0 across all platform-specific requirements files and setup.py
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/azure-cli/setup.py | Updated websocket-client compatible release specifier to ~=1.8.0 |
| src/azure-cli/requirements.py3.windows.txt | Pinned websocket-client to exact version 1.8.0 for Windows |
| src/azure-cli/requirements.py3.Linux.txt | Pinned websocket-client to exact version 1.8.0 for Linux |
| src/azure-cli/requirements.py3.Darwin.txt | Pinned websocket-client to exact version 1.8.0 for macOS |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.