-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[Storage] BREAKING CHANGE: az storage account create/update: Remove --min-tls-version values TLS1_0, TLS1_1
#32740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
calvinhzy
wants to merge
3
commits into
Azure:dev
Choose a base branch
from
calvinhzy:break-tls-1.0
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+36
−549
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
14 changes: 0 additions & 14 deletions
14
src/azure-cli/azure/cli/command_modules/storage/_breaking_change.py
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -324,8 +324,8 @@ def load_arguments(self, _): # pylint: disable=too-many-locals, too-many-statem | |
| c.argument('account_name', acct_name_type, options_list=['--name', '-n'], local_context_attribute=None) | ||
|
|
||
| with self.argument_context('storage account create', resource_type=ResourceType.MGMT_STORAGE) as c: | ||
| t_account_type, t_sku_name, t_kind, t_tls_version, t_dns_endpoint_type, t_zone_placement_policy = \ | ||
| self.get_models('AccountType', 'SkuName', 'Kind', 'MinimumTlsVersion', 'DnsEndpointType', | ||
| t_account_type, t_sku_name, t_kind, t_dns_endpoint_type, t_zone_placement_policy = \ | ||
| self.get_models('AccountType', 'SkuName', 'Kind', 'DnsEndpointType', | ||
| 'ZonePlacementPolicy', | ||
| resource_type=ResourceType.MGMT_STORAGE) | ||
| t_identity_type = self.get_models('IdentityType', resource_type=ResourceType.MGMT_STORAGE) | ||
|
|
@@ -388,10 +388,9 @@ def load_arguments(self, _): # pylint: disable=too-many-locals, too-many-statem | |
| 'be configured for public access. Note that setting this property to true does ' | ||
| 'not enable anonymous access to any data in the account. The additional step of configuring the ' | ||
| 'public access setting for a container is required to enable anonymous access.') | ||
| c.argument('min_tls_version', arg_type=get_enum_type(t_tls_version), | ||
| c.argument('min_tls_version', arg_type=get_enum_type(['TLS1_2', 'TLS1_3']), | ||
| help='The minimum TLS version to be permitted on requests to storage. ' | ||
| ' Values TLS1_0 and TLS1_1 have been retired on 2026/02/03 and will be removed on 2026/03/03.' | ||
| ' Microsoft recommends setting MinimumTlsVersion to TLS1_2') | ||
| 'Microsoft recommends setting MinimumTlsVersion to TLS1_2') | ||
| c.argument('allow_shared_key_access', allow_shared_key_access_type) | ||
| c.argument('edge_zone', edge_zone_type) | ||
| c.argument('identity_type', arg_type=get_enum_type(t_identity_type), arg_group='Identity', | ||
|
|
@@ -468,7 +467,6 @@ def load_arguments(self, _): # pylint: disable=too-many-locals, too-many-statem | |
| c.argument('description', help='Comments for {} operation.'.format(item)) | ||
|
|
||
| with self.argument_context('storage account update', resource_type=ResourceType.MGMT_STORAGE) as c: | ||
| t_tls_version = self.get_models('MinimumTlsVersion', resource_type=ResourceType.MGMT_STORAGE) | ||
| t_identity_type = self.get_models('IdentityType', resource_type=ResourceType.MGMT_STORAGE) | ||
| c.register_common_storage_account_options() | ||
| c.argument('sku', arg_type=get_enum_type(t_sku_name), | ||
|
|
@@ -507,10 +505,9 @@ def load_arguments(self, _): # pylint: disable=too-many-locals, too-many-statem | |
| 'in the account may be configured for public access. Note that setting this property to true does ' | ||
| 'not enable anonymous access to any data in the account. The additional step of configuring the ' | ||
| 'public access setting for a container is required to enable anonymous access.') | ||
| c.argument('min_tls_version', arg_type=get_enum_type(t_tls_version), | ||
| c.argument('min_tls_version', arg_type=get_enum_type(['TLS1_2', 'TLS1_3']), | ||
| help='The minimum TLS version to be permitted on requests to storage. ' | ||
| ' Values TLS1_0 and TLS1_1 have been retired on 2026/02/03 and will be removed on 2026/03/03.' | ||
| ' Microsoft recommends setting MinimumTlsVersion to TLS1_2') | ||
| 'Microsoft recommends setting MinimumTlsVersion to TLS1_2') | ||
|
Comment on lines
+508
to
+510
|
||
| c.argument('allow_shared_key_access', allow_shared_key_access_type) | ||
| c.argument('identity_type', arg_type=get_enum_type(t_identity_type), arg_group='Identity', | ||
| help='The identity type.') | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that TLS1_0/TLS1_1 are removed from the argument choices, it would be good to add a scenario test that verifies
az storage account create --min-tls-version TLS1_0|TLS1_1fails with an appropriate error (e.g.,expect_failure=True). This will prevent accidental reintroduction and documents the breaking behavior.