[ACR] az acr login: Add refreshToken and username fields to the output after using --expose-token parameter#31091
Merged
zhoxing-ms merged 17 commits intoAzure:devfrom May 19, 2025
wangxiaoxuan273:add-refresh-token-field
Merged
[ACR] az acr login: Add refreshToken and username fields to the output after using --expose-token parameter#31091zhoxing-ms merged 17 commits intoAzure:devfrom wangxiaoxuan273:add-refresh-token-field
az acr login: Add refreshToken and username fields to the output after using --expose-token parameter#31091zhoxing-ms merged 17 commits intoAzure:devfrom
wangxiaoxuan273:add-refresh-token-field
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @wangxiaoxuan273, |
️✔️AzureCLI-BreakingChangeTest
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
wangzelin007,
yonzhan and
zhoxing-ms
microsoft-github-policy-service
bot
added
Auto-Assign
wangxiaoxuan273
changed the title
refreshToken field to the output of az acr login --expose-tokenrefreshToken and username fields to the output of az acr login --expose-token
Wwwsylvia
reviewed
Mar 20, 2025
Contributor
Wwwsylvia
left a comment
Wwwsylvia
left a comment
There was a problem hiding this comment.
This is not a breaking change, is it?🤔
|
@Wwwsylvia and @wangxiaoxuan273 Can we add tests here in this test file to validate that Right now, the refresh token tests only validate that the method was called with certain arguments. Please validate that the output also contains both the existing and new fields we added. |
Member
Author
You are right, we are not changing the |
wangxiaoxuan273
changed the title
refreshToken and username fields to the output of az acr login --expose-tokenrefreshToken and username fields to the output of az acr login --expose-token
johnsonshi
suggested changes
Mar 21, 2025
added 2 commits
March 24, 2025 16:49
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
johnsonshi
approved these changes
Mar 26, 2025
johnsonshi
left a comment
johnsonshi
left a comment
There was a problem hiding this comment.
Thank you for adding the tests. I am approving the PR now - however, I have one small request for you to change in the diagnostics.
added 3 commits
March 27, 2025 12:40
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Member
Author
|
@jsntcy @yanzhudd @zhoxing-ms Can you review and merge this PR? Thanks |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 31091 in repo Azure/azure-cli |
added 2 commits
April 8, 2025 15:46
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Wwwsylvia
suggested changes
Apr 18, 2025
Contributor
|
please note that Azure CLI will have a code freeze on 04/21/2025 07:00 UTC for the upcoming release. Please address the comments ASAP, otherwise it has to be postponed to next sprint (05-19). |
yanzhudd
modified the milestones:
May 2025 (2025-05-06),
Build 2025 (2025-05-19)❗ Breaking change release ❗
Contributor
|
Could you please resolve these CI issues and conflicts? |
zhoxing-ms
modified the milestones:
Build 2025 (2025-05-19)❗ Breaking change release ❗,
Backlog,
June 2025 (2025-06-03)
added 7 commits
May 14, 2025 10:55
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
zhoxing-ms
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
changes the output of
az acr login --expose-token.Fixes #20689
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.