[ARO] az aro create: Update VM SKU to align with best practices#31074
Merged
[ARO] az aro create: Update VM SKU to align with best practices#31074
az aro create: Update VM SKU to align with best practices#31074Conversation
️✔️AzureCLI-FullTest
|
|
Hi @shubhadapaithankar, |
❌AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
the
customer-reported
edisonLcardenas
approved these changes
Mar 19, 2025
shubhadapaithankar
force-pushed
the
update-vm-sku
branch
3 times, most recently
from
bc5792a to
465cc1c
Compare
shubhadapaithankar
force-pushed
the
update-vm-sku
branch
from
465cc1c to
82e6a26
Compare
shubhadapaithankar
changed the title
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Commenter does not have sufficient privileges for PR 31074 in repo Azure/azure-cli |
shubhadapaithankar
changed the title
az aro create: Update VM SKU to align with best practices
Contributor
Author
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
Collaborator
|
Please fix CI issues |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 31074 in repo Azure/azure-cli |
Contributor
Author
|
Hey yonzhan, it looks like the |
kairu-ms
approved these changes
Mar 21, 2025
Contributor
kairu-ms
left a comment
kairu-ms
left a comment
There was a problem hiding this comment.
LGTM. Currently there's an issue in our CI pipeline. Will merge it after the pipeline can work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aro createDescription
This PR updates the VM SKU for Azure Red Hat OpenShift (ARO) in accordance with the Upstream CLI v5 default changes. This aligns with the latest recommended defaults for performance and stability.
What Changed?
Effect of Changes
History Notes
[ARO]
az aro create: Update VM SKU to align with best practicesThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.