[App Service] Fix: #21721: az webapp config storage-account add: Add validation for non-existent FileShare#30990
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
calvinhzy,
evelyn-ys,
wangzelin007 and
yonzhan
|
Please fix CI issues |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@seligj95 I want to confirm that the newly added validation will not cause any breaking changes to customers, right? |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
zhoxing-ms
changed the title
az webapp config storage-account add: Add validation for non-existent FileShareaz webapp config storage-account add: Add validation for non-existent FileShare
@zhoxing-ms - I wouldn't consider this a breaking change. This adds validation so that customers won't break their apps. If you add a FileShare that doesn't exist, the app stops working. So I added validation to check if the FileShare exists before it's added to ensure this command won't lead to a broken app. This might break some customer's pipelines if they are adding FileShares that don't exist for some reason, but I think this change is necessary to ensure that doesn't happen. If you think this is a breaking change, please let me know. Otherwise, I think it's fine to proceed. |
|
Make sense, thanks for your detailed explain~ @seligj95 |
|
Hi @seligj95, @zhoxing-ms FYI. this azure pipeline task https://learn.microsoft.com/en-us/azure/devops/pipelines/tasks/reference/azure-cli-v2?view=azure-pipelines downloads latest cli version and is now broken for us. |
|
additionally, it is expecting the file share to exist in the same resource group as the app. In our case, the storage account is in a different resource group. So, even if I add a dummy file share to bypass the validation, it does not work. |
|
@zhoxing-ms can we roll this back? i need to dig deeper into the solution for this |
|
Opened a PR with a hotfix #31237 to remove this validation |
6 participants
Related command
az webapp config storage-account add
Description
Fixes #21721
Testing Guide
The following command now returns an error when <FILE_SHARE_NAME> doesn't exist in the target storage account:
az webapp config storage-account add -g <RESSOURCE_GROUP_NAME> -n <APP_SERVICE_NAME> --custom-id "test-az-cli" --storage-type AzureFiles --account-name <STORAGE_ACCOUNT_NAME> --share-name <FILE_SHARE_NAME> --access-key <STORAGE_ACCOUNT_ACCESS_KEY> --mount-path <MOUNT_PATH_ON_APP_SERVICE_FS>
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.