[Containerapp] Fix #30828: az containerapp job stop: Fix TypeError when --job-execution-name is not specified#30941
Merged
zhoxing-ms merged 4 commits intodevfrom Mar 7, 2025
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
JennyLawrance,
chinadragon0515,
ebencarek,
jijohn14,
jsntcy,
pagariyaalok,
ruslany,
sanchitmehta,
torosent,
vinisoto,
vturecek,
wangzelin007,
yanzhudd,
yonzhan and
zhoxing-ms
Greedygre
changed the title
az containerapp job stop: Fix TypeErroraz containerapp job stop: Fix TypeError when doesn't specify --job-execution-name
Contributor
Author
|
Hi @zhoxing-ms @wangzelin007 |
ShichaoQiu
approved these changes
Mar 6, 2025
yanzhudd
changed the title
az containerapp job stop: Fix TypeError when doesn't specify --job-execution-nameaz containerapp job stop: Fix TypeError when --job-execution-name is not specified
yanzhudd
approved these changes
Mar 6, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
approved these changes
Mar 6, 2025
Contributor
Author
|
Wait for PR about updating containerapp code owner to merge: #30964 |
zhoxing-ms
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Fix issue: #30828 (comment)
Description
When execute command
az containerapp job stop --job-execution-name, the response payload is empty.When execute command
az containerapp job stopwithout--job-execution-name, the response payload is an list in an object that includes the executions being stopped.{"value":[]}or
We need to return the
jsonof the object, otherwise it will throw error as following:Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.