[ACR] az acr login: Fix login status code when command fails#30917
[ACR] az acr login: Fix login status code when command fails#30917
az acr login: Fix login status code when command fails#30917Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
wangzelin007 and
yonzhan
microsoft-github-policy-service
bot
added
the
customer-reported
microsoft-github-policy-service
bot
added
Auto-Assign
ronlv4
changed the title
|
Please note that the PR for breaking change must be released in the breaking change window, but you need to consider pre-pronouncing the breaking change to the customer in advance. For more details, please refer to this doc: https://github.com/Azure/azure-cli/blob/dev/doc/how_to_introduce_breaking_changes.md |
|
@microsoft-github-policy-service agree company="Microsoft" |
ronlv4
requested review from
Greedygre,
Juliehzl,
calvinhzy,
evelyn-ys and
howang-ms
as code owners
|
I should be more precise on the issue, the status code is 0 when the command fails for docker login, meaning it passed the internal az acr validations (for existing subscription and acr). |
zhoxing-ms
changed the title
az acr login: Fix login status code when command failsaz acr login: Fix login status code when command fails
|
please note that Azure CLI will have a code freeze on 05/27/2025 07:00 UTC for the upcoming release. Please address these CI issues ASAP, otherwise it has to be postponed to next sprint (07-01). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Could you please pull the latest code from remote dev branch to see if it can resolve this CI issue? |
done |
|
/azp run |
1 similar comment
|
/azp run |
|
@ronlv4 This PR encountered some issues of Github that prevented it from triggering the CI pipeline again. Could you please create a new PR with the same functionality? Then we will replace this PR with the new one, and then merge the new PR |
opened #31692 . |
7 participants
Related command
az acr login
Description
When az acr login fails for docker login, the command should return a non-zero status code.
Why wasn't this the case? the check was if stderr is not empty. In the case docker is not running, stderr is empty and the error is written to stdout:
fixes #27907
Testing Guide
Test acr module
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.