[AKS] az aks: Fix outbound type validation error msg
#30886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinForReal
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
MartinForReal
changed the title
microsoft-github-policy-service
bot
requested review from
FumingZhang and
yonzhan
microsoft-github-policy-service
bot
added
Auto-Assign
FumingZhang
reviewed
Feb 25, 2025
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
lgtm
could you also apply the change to aks-preview?
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Fan Shang Xiang <[email protected]>
zhoxing-ms
changed the title
zhoxing-ms
approved these changes
Feb 28, 2025
zhoxing-ms
changed the title
az aks: Fix outbound type validation error msg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
'az aks create/update'
Description
Fix error message when outbound type validation failed.
Testing Guide
update cluster and set vnet_subnet_id with outbound type loadbalancer.
History Notes
[aks]
az aks: Fix error message when outbound type validation failedThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.