Conversation
Shi1810
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @Shi1810, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| webapp deploy | cmd webapp deploy added parameter enable_kudu_warmup |
||
| webapp deployment source config-zip | cmd webapp deployment source config-zip added parameter enable_kudu_warmup |
||
| webapp up | cmd webapp up added parameter enable_kudu_warmup |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
the
customer-reported
Contributor
|
Thank you for your contribution Shi1810! We will review the pull request and get back to you soon. |
sarsharma
reviewed
Feb 24, 2025
sarsharma
reviewed
Feb 24, 2025
Member
|
Please follow https://github.com/Azure/azure-cli/tree/dev/doc/authoring_command_modules#submitting-pull-requests Also can you please add how you tested the changes in the PR description |
sarsharma
reviewed
Feb 24, 2025
sarsharma
reviewed
Feb 24, 2025
sarsharma
reviewed
Feb 24, 2025
sarsharma
reviewed
Feb 24, 2025
sarsharma
reviewed
Feb 24, 2025
sarsharma
reviewed
Feb 24, 2025
sarsharma
reviewed
Feb 24, 2025
sarsharma
reviewed
Feb 24, 2025
surenderssm
reviewed
Feb 24, 2025
surenderssm
reviewed
Feb 24, 2025
surenderssm
reviewed
Feb 24, 2025
surenderssm
reviewed
Feb 24, 2025
surenderssm
reviewed
Feb 24, 2025
sarsharma
reviewed
Feb 24, 2025
sarsharma
reviewed
Feb 24, 2025
sarsharma
reviewed
Feb 24, 2025
sarsharma
reviewed
Feb 24, 2025
sarsharma
reviewed
Feb 24, 2025
sarsharma
reviewed
Feb 24, 2025
sarsharma
reviewed
Feb 24, 2025
sarsharma
reviewed
Feb 24, 2025
sarsharma
reviewed
Feb 24, 2025
sarsharma
reviewed
Feb 24, 2025
added 3 commits
February 24, 2025 20:31
surenderssm
reviewed
Feb 24, 2025
surenderssm
reviewed
Feb 24, 2025
surenderssm
reviewed
Feb 24, 2025
Member
surenderssm
left a comment
surenderssm
left a comment
There was a problem hiding this comment.
Looks good to me, looking forward for the impact.
Shi1810
changed the title
az webapp up az webapp deploy az webapp deployment source config-zip` : Warm-up kudu before making scm one-deployment and zip-deployment
Shi1810
changed the title
az webapp up az webapp deploy az webapp deployment source config-zip` : Warm-up kudu before making scm one-deployment and zip-deploymentaz webapp up , az webapp deploy , az webapp deployment source config-zip : Warm-up kudu before making scm one-deployment and zip-deployment
Contributor
Author
@microsoft-github-policy-service agree [company="Microsoft"] |
Contributor
Author
@microsoft-github-policy-service agree |
added 2 commits
February 25, 2025 03:05
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
updated the history notes with newly added parameter, as it is more clear for users to use the new feature |
sarsharma
approved these changes
Feb 25, 2025
yanzhudd
approved these changes
Feb 25, 2025
CustardTart32
pushed a commit
to CustardTart32/azure-cli
that referenced
this pull request
Feb 27, 2025
…ment source config-zip` : Warm-up kudu before making scm one-deployment and zip-deployment (Azure#30872)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az webapp upaz webapp deployaz webapp deployment source config-zipDescription
Kudu cold-start has a timeout of 240 seconds, if kudu do not start within this time-interval, customers see timeout message.
The intension behind this PR is to warm-up kudu before making scm one-deploy and zip-deploy.
Approach:
We have also created a feature flag: enable-kudu-warmup, which controls this feature.
Screenshots:
az webapp up
az webapp deploy
az webapp deployment source config-zip
Testing Guide
Deploying app using az webapp up, az webapp deploy and az webapp deployment source config-zip should work as expected.
History Notes
[App Service]
az webapp up: Add--enable-kudu-warmupparameter to support warm-up Kudu before making deployment[App Service]
az webapp deploy: Add--enable-kudu-warmupparameter to support warm-up Kudu before making deployment[App Service]
az webapp deployment source config-zip: Add--enable-kudu-warmupparameter to support warm-up Kudu before making deploymentThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.