{Compute} az disk-access: Migrate to Code Gen V2
#30869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanzhudd
requested review from
jsntcy,
wangzelin007 and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @yanzhudd, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| disk-access create | cmd disk-access create update parameter disk_access_name: added property aaz_type=string |
||
| disk-access create | cmd disk-access create update parameter disk_access_name: added property type=string |
||
| disk-access create | cmd disk-access create update parameter disk_access_name: removed property id_part=name |
||
| disk-access create | cmd disk-access create update parameter disk_access_name: updated property options from ['--name', '-n'] to ['--disk-access-name', '--name', '-n'] |
||
| disk-access create | cmd disk-access create update parameter location: added property aaz_type=string |
||
| disk-access create | cmd disk-access create update parameter location: updated property type from custom_type to string |
||
| disk-access create | cmd disk-access create update parameter no_wait: added property aaz_type=bool |
||
| disk-access create | cmd disk-access create update parameter no_wait: added property choices=['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes'] |
||
| disk-access create | cmd disk-access create update parameter no_wait: added property nargs=? |
||
| disk-access create | cmd disk-access create update parameter no_wait: added property type=bool |
||
| disk-access create | cmd disk-access create update parameter resource_group_name: added property aaz_type=string |
||
| disk-access create | cmd disk-access create update parameter resource_group_name: added property type=string |
||
| disk-access create | cmd disk-access create update parameter resource_group_name: updated property name from resource_group_name to resource_group |
||
| disk-access create | cmd disk-access create update parameter tags: added property aaz_type=AAZDictArg |
||
| disk-access create | cmd disk-access create update parameter tags: added property type=Dict<String,String> |
||
| disk-access create | cmd disk-access create update parameter tags: updated property nargs from * to + |
||
| disk-access list | cmd disk-access list added parameter pagination_limit |
||
| disk-access list | cmd disk-access list added parameter pagination_token |
||
| disk-access update | cmd disk-access update added parameter location |
||
| disk-access update | cmd disk-access update update parameter disk_access_name: added property aaz_type=string |
||
| disk-access update | cmd disk-access update update parameter disk_access_name: added property type=string |
||
| disk-access update | cmd disk-access update update parameter disk_access_name: updated property options from ['--name', '-n'] to ['--disk-access-name', '--name', '-n'] |
||
| disk-access update | cmd disk-access update update parameter no_wait: added property aaz_type=bool |
||
| disk-access update | cmd disk-access update update parameter no_wait: added property choices=['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes'] |
||
| disk-access update | cmd disk-access update update parameter no_wait: added property nargs=? |
||
| disk-access update | cmd disk-access update update parameter no_wait: added property type=bool |
||
| disk-access update | cmd disk-access update update parameter properties_to_add: added property aaz_type=AAZGenericUpdateAddArg |
||
| disk-access update | cmd disk-access update update parameter properties_to_remove: added property aaz_type=AAZGenericUpdateRemoveArg |
||
| disk-access update | cmd disk-access update update parameter properties_to_set: added property aaz_type=AAZGenericUpdateSetArg |
||
| disk-access update | cmd disk-access update update parameter resource_group_name: added property aaz_type=string |
||
| disk-access update | cmd disk-access update update parameter resource_group_name: added property type=string |
||
| disk-access update | cmd disk-access update update parameter resource_group_name: updated property name from resource_group_name to resource_group |
||
| disk-access update | cmd disk-access update update parameter tags: added property aaz_type=AAZDictArg |
||
| disk-access update | cmd disk-access update update parameter tags: added property type=Dict<String,String> |
||
| disk-access update | cmd disk-access update update parameter tags: updated property nargs from * to + |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
the
Compute
zhoxing-ms
approved these changes
Feb 24, 2025
CustardTart32
pushed a commit
to CustardTart32/azure-cli
that referenced
this pull request
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az disk-access create/updateDescription
AAZ PR: Azure/aaz#696
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.