-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[AKS] az aks create/az aks nodepool add: Add message of the day option --message-of-the-day
#30862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @UtheMan, |
❌AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
c5da84a to
7f08f4c
Compare
|
Queued live test to validate the change, test passed! |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
src/azure-cli/azure/cli/command_modules/acs/agentpool_decorator.py
Outdated
Show resolved
Hide resolved
bf98556 to
b34f269
Compare
|
Thanks @FumingZhang / @yanzhudd . I think I fixed the errors - could you please help with retriggering the CI checks? Seems like I cannot do it myself. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
az aks create/az aks nodepool add: Add message of the day option --message-of-the-day
…ion `--message-of-the-day` (Azure#30862)
Related command
Description
Add message of the day option --message-of-the-day to enable users to specify a message of the day for their AKS nodes using GA CLI.
Testing Guide
History Notes
[AKS]
az aks create: Add--message-of-the-dayparameter to support message of the day[AKS]
az aks nodepool add: Add--message-of-the-dayparameter to support message of the dayThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.