[App Service] Fix #28858: az webapp config container set: Add support for managed identity pull from ACR
#30855
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @madsd, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| webapp config container set | cmd webapp config container set added parameter acr_identity |
||
| webapp config container set | cmd webapp config container set added parameter acr_use_identity |
||
| webapp config container set | cmd webapp config container set added parameter assign_identities |
||
| webapp config container set | cmd webapp config container set added parameter role |
||
| webapp config container set | cmd webapp config container set added parameter scope |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
wangzelin007 and
yonzhan
microsoft-github-policy-service
bot
added
Auto-Assign
|
Fixes: #28858 |
zhoxing-ms
changed the title
az webapp config container set Add support for managed identity pull from ACR. Fix #28858az webapp config container set: Add support for managed identity pull from ACR
|
For the managed assigned identity related parameters, please refer this unified specification document to design them managed_identity_command_guideline.md |
...ure-cli/azure/cli/command_modules/appservice/tests/latest/sample_custom_container/Dockerfile
Outdated
Show resolved
Hide resolved
...ure-cli/azure/cli/command_modules/appservice/tests/latest/sample_custom_container/index.html
Outdated
Show resolved
Hide resolved
@zhoxing-ms is it the --assign-identities property that you want to split in two and rename to --mi-system-assigned and --mi-user-assigned? |
|
@madsd If there is a similar scenario design in the app service before, it can be implemented according to the previous design and migrated uniformly in the future. Otherwise, it is recommended to design commands according to the specifications in the document |
|
@zhoxing-ms Yes, I did chose this implementation to match existing patterns in the az webapp commands so I think we should keep the current design and do a uniform migration in the future. Thanks |
|
please note that Azure CLI will have a code freeze on 04/21/2025 07:00 UTC for the upcoming release. Please address the comments ASAP, otherwise it has to be postponed to next sprint (05-19). |
yanzhudd
modified the milestones:
May 2025 (2025-05-06),
Build 2025 (2025-05-19)❗ Breaking change release ❗
|
Removed flaky test - there are already existing tests verifying managed identity and container image pull. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
could you please add some tests for the new added parameters? |
|
@madsd Could you please resolve these conflicts and comments? |
|
please note that Azure CLI will have a code freeze on 06/24/2025 07:00 UTC for the upcoming release. Please address these CI issues ASAP, otherwise it has to be postponed to next sprint (08-05). |
|
@madsd Any update? |
|
Please note that Azure CLI will freeze the code on 07/29/2025 07:00 UTC for the upcoming release. If you want to catch this release train, please resolve these comments ASAP, otherwise this PR has to be postponed to next sprint. |
zhoxing-ms
modified the milestones:
August 2025 (2025-08-05),
September 2025 (2025-09-02)
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
please note that the code completion date for the upcoming release is 08/26/2025 at 07:00 UTC. If you want to catch this release train, please address the comments ASAP, otherwise it has to be postponed to next sprint (10/14). |
5 participants
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.