Skip to content

[Compute] az vmss update: Fix unexpected behavior applying instance protection to scale sets #30854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jing-song wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[Compute] az vmss update: Fix unexpected behavior applying instance protection to scale sets #30854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/azure-cli/azure/cli/command_modules/vm/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4085,12 +4085,19 @@ def update_vmss(cmd, resource_group_name, name, license_type=None, no_wait=False
if not vmss.protection_policy:
vmss.protection_policy = VMProtectionPolicy()

if protect_from_scale_in is not None:
vmss.protection_policy.protect_from_scale_in = protect_from_scale_in

if protect_from_scale_set_actions is not None:
vmss.protection_policy.protect_from_scale_set_actions = protect_from_scale_set_actions

if protect_from_scale_in is not None:
vmss.protection_policy.protect_from_scale_in = protect_from_scale_in
VirtualMachineScaleSetVM = cmd.get_models('VirtualMachineScaleSetVM')
kwargs['parameters'] = VirtualMachineScaleSetVM(protection_policy=kwargs['parameters'].protection_policy,
location=kwargs['parameters'].location,
license_type=kwargs['parameters'].license_type,
user_data=kwargs['parameters'].user_data)
return sdk_no_wait(no_wait, client.virtual_machine_scale_set_vms.begin_update,
resource_group_name, name, instance_id, **kwargs)

return sdk_no_wait(no_wait, client.virtual_machine_scale_set_vms.begin_update,
resource_group_name, name, instance_id, **kwargs)

Expand Down
Loading