[RDBMS] BREAKING CHANGE: az postgres flexible-server update: Add user confirmation on certain update operations
#30731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…certain update operations
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| postgres flexible-server update | cmd postgres flexible-server update removed property deprecate_info_target |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Member
nachoalonsoportillo
left a comment
nachoalonsoportillo
left a comment
There was a problem hiding this comment.
Other than the suggested change to the comment, it looks good to me
src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_custom_postgres.py
Outdated
Show resolved
Hide resolved
mattboentoro
changed the title
az postgres flexible-server update: add user confirmation on certain update operationsaz postgres flexible-server update: Add user confirmation on certain update operations
Member
|
We can't merge this PR until next breaking change window (Build release) |
Contributor
Author
|
Hey @evelyn-ys, when can we expect this to be merged? |
Collaborator
|
Please fix conflicts first. |
Member
|
Pls be aware that we allow breaking changes twice a year and next breaking change window is May 2025 |
evelyn-ys
modified the milestones:
May 2025 (2025-05-06),
Build 2025 (2025-05-19)❗ Breaking change release ❗
Member
|
@mattboentoro Pls resolve conflicts |
…mattboentoro/add-user-confirmation
…mattboentoro/add-user-confirmation
Member
|
Please make sure to update : src/azure-cli/azure/cli/command_modules/rdbms/_breaking_change.py |
added 2 commits
May 7, 2025 21:58
…mattboentoro/add-user-confirmation
mattboentoro
changed the title
az postgres flexible-server update: Add user confirmation on certain update operationsaz postgres flexible-server update: Add user confirmation on certain update operations
Contributor
Author
|
@evelyn-ys do you mind reviewing this PR? |
nasc17
approved these changes
May 8, 2025
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
evelyn-ys
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az postgres flexible-server update
Description
Add user confirmation on certain update operations:
storage_gbandinstance.storage.type== "PremiumV2_LRS" andinstance.storage.storage_size_gb!=storage_gbsku_nameandinstance.sku.name!=sku_namestorage_gbandinstance.storage.type== "" andstorage_gb> 4096 andinstance.storage.storage_size_gb<= 4096Testing Guide
Manual testing
History Notes
[RDBMS] BREAKING CHANGE:
az postgres flexible-server update: Add user confirmation on certain update operationsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.