{Packaging} Accelerate command execution in Docker image with warm start#30643
Merged
{Packaging} Accelerate command execution in Docker image with warm start#30643
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
jiasli,
wangzelin007 and
yonzhan
bebound
changed the title
bebound
force-pushed
the
warm-start
branch
2 times, most recently
from
77cf0e8 to
cdf681e
Compare
jiasli
reviewed
Jan 20, 2025
Co-authored-by: Jiashuo Li <[email protected]>
jiasli
approved these changes
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Call
az versionduring docker build to generate command index. This should accelerate the first command execution speed.It adds these files in
~/.azure, and onlycommandIndex.jsonis kept in the image.This reminds me of #19183, where the user complains that the first invocation is slow.
CLI also tries to get latest version from GitHub and save
versionCheck.jsonin fresh installation, which takes 2s on my machine. I believe it's also not necessary. Source code:azure-cli/src/azure-cli-core/azure/cli/core/__init__.py
Line 85 in a29d2e7
When releasing new docker image, the main branch version is not changed yet, so the
versionCheck.jsonis outdated. I don't want to cache an outdated file. #30671 fixes this issue.Testing Guide