[Container app] az containerapp create: Fix to make --registry-username value to be DNS1123 compliant
#30563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
|
zhoxing-ms
modified the milestones:
January 2025 (2025-01-14),
February 2025 (2025-02-11)
Contributor
|
Please follow this guideline to refine the title and description section |
Contributor
|
Please add some tests to verify the changes. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
Please note Azure CLI will freeze the code on 01/28/2025 10:00 UTC for the upcoming release. If you want to catch this release train, please get this PR ready ASAP, otherwise it has to be postponed to next sprint. |
Contributor
Please mark this PR as a draft PR if this PR is not ready to be reviewed yet |
william-msft
changed the title
william-msft
changed the title
az containerapp create: Fix to make registry_user DNS1123 compliant
william-msft
requested review from
Greedygre,
Juliehzl and
howang-ms
as code owners
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
Please add test for this fix, refer test case: |
…com/william-msft/azure-cli into williamhe/fix-user-validation-error
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 30563 in repo Azure/azure-cli |
Contributor
Author
|
@yanzhudd @Greedygre could one of you re-run the pipeline please? I don't have enough permission. Thank you. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Greedygre
reviewed
Feb 8, 2025
src/azure-cli/azure/cli/command_modules/containerapp/tests/latest/test_containerapp_commands.py
Outdated
Show resolved
Hide resolved
…com/william-msft/azure-cli into williamhe/fix-user-validation-error
… a username value
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Greedygre
previously approved these changes
Feb 12, 2025
Greedygre
reviewed
Feb 12, 2025
Greedygre
reviewed
Feb 12, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Greedygre
approved these changes
Feb 12, 2025
Contributor
|
Can you help to review and approve this PR when you have chance? Thanks! |
yanzhudd
changed the title
az containerapp create: Fix to make registry_user DNS1123 compliantaz containerapp create: Fix to make --registry-username value to be DNS1123 compliant
yanzhudd
approved these changes
Feb 12, 2025
CustardTart32
pushed a commit
to CustardTart32/azure-cli
that referenced
this pull request
Feb 27, 2025
…rname` value to be `DNS1123` compliant (Azure#30563)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Performing the related command above will fail because the
@symbol will cause an error:This fix will force the
registry-usernamevalue to be DNS1123 compliant.Testing Guide
Below is a screenshot of my manual test this change
Since this is not testable with the existing E2E framework. The reason is because ACR/MCR does not support email as a username value and our customers want to use registries like JFrog, DockerHub, etc. Which allow email address as a username.
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.