[containerapp] az containerapp [create/update] --environment-mode WorkloadProfiles Add environment mode to az containerapp#9551
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| containerapp env create | cmd containerapp env create added parameter environment_mode |
||
| containerapp env update | cmd containerapp env update added parameter environment_mode |
|
Hi @jepetty, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
faf4f9a to
214eb2f
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… are not obsolete
a8a7d95 to
67ed69a
Compare
| with self.argument_context('containerapp env') as c: | ||
| c.argument('public_network_access', arg_type=get_enum_type(['Enabled', 'Disabled']), | ||
| help="Allow or block all public traffic", is_preview=True) | ||
| c.argument('environment_mode', options_list=["--environment-mode"], help="Mode of the environment.", is_preview=True) |
There was a problem hiding this comment.
What is the value allowed?
Recommend to use arg_type=get_enum_type(["consumptiononly"]) to make it more clear.
There was a problem hiding this comment.
We don't want to constrain the type right now because we're introducing several experimental values and names may frequently change.
|
May I ask why do we need to add --environment-mode? Seems this change not relate to backend feature? We already have |
Base on the code, the I think in portal, we already deprecate |
@Greedygre great question! Chatted a bit offline, but including here as well We're in the process of experimenting with new environment types aside from our v1 ConsumptionOnly and v2 Dedicated/Consumption environments. We're experimenting with better experiences for our users - both in terms of speed of provisioning/environment creation and in terms of cost-savings. I do think we should consider deprecating the |
|
Updated the PR description to provide additional background for this change - thanks for the questions, @Greedygre! |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az containerapp env create --name --resource-group --environment-mode WorkloadProfiles
az containerapp env update --name --resource-group --environment-mode WorkloadProfiles
Why this change over the existing
--enable-workload-profilesswitch?The Azure Container Apps team is experimenting with new environment types beyond just ConsumptionOnly and Dedicated/Consumption leveraging new technologies. This change enable us to rapidly iterate on this experimentation by easily creating new environments, as well as ensure the experience of creation through CLI is prioritized the entire time.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.