Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGC-v2025.01.01 WAF #8451

Merged
merged 4 commits into from
Feb 4, 2025
Merged

AGC-v2025.01.01 WAF #8451

merged 4 commits into from
Feb 4, 2025

Conversation

cdxu-147
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az network alb create
az network alb delete
az network alb update
az network alb show
az network alb list
az network alb frontend create
az network alb frontend delete
az network alb frontend update
az network alb frontend show
az network alb frontend list
az network alb association create
az network alb association delete
az network alb association update
az network alb association show
az network alb association list
az network alb security-policy waf create
az network alb security-policy waf delete
az network alb security-policy waf update
az network alb security-policy show
az network alb security-policy list

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Sorry, something went wrong.

Copy link

azure-client-tools-bot-prd bot commented Jan 31, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️alb
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd network alb association update cmd network alb association update added parameter association_type
⚠️ 1006 - ParaAdd network alb association update cmd network alb association update added parameter subnet
⚠️ 1006 - ParaAdd network alb create cmd network alb create added parameter waf_policy_id
⚠️ 1011 - SubgroupAdd network alb security-policy sub group network alb security-policy added
⚠️ 1006 - ParaAdd network alb update cmd network alb update added parameter waf_policy_id

Copy link

Hi @cdxu-147,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 31, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Jan 31, 2025

Hi @cdxu-147

⚠️ Release Requirements

Module: alb

  • ⚠️ Please update VERSION to be 1.0.0b2 in src/alb/setup.py

Notes

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jan 31, 2025
@necusjz
Copy link
Member

necusjz commented Feb 2, 2025

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz necusjz added skip-cal-version and removed release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. labels Feb 2, 2025
@necusjz necusjz merged commit a46887d into Azure:main Feb 4, 2025
28 of 30 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Feb 4, 2025

[Release] Update index.json for extension [ alb-2.0.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=114204781&view=results

Jenniferyingni pushed a commit to Jenniferyingni/azure-cli-extensions that referenced this pull request Feb 9, 2025
* waf cli

* waf-cli

* fix linter

* udpate history
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants