Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate blueprint commands #8419

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dantedallag
Copy link

Commit to start deprecation process of the az blueprint commands.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az blueprint

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jan 15, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️blueprint
rule cmd_name rule_message suggest_message
⚠️ 1013 - SubgroupPropAdd blueprint sub group blueprint added property deprecate_info_target

Copy link

Hi @dantedallag,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 15, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Jan 15, 2025

@kairu-ms
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms
Copy link
Contributor

Please fix the ci issues. BTW, it deserve a new extension version for release to public

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jan 16, 2025
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jan 16, 2025
@dantedallag
Copy link
Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 8419 in repo Azure/azure-cli-extensions

@dantedallag
Copy link
Author

@kairu-ms I made the requested changes from the comments, except for the test case failures in CI. Our team owns blueprints, but we did not author these commands. I don't think I have the proper context to fix these test case errors and am also unsure why test cases are breaking if I did not make any functional changes?

Could you help out here?

@dantedallag
Copy link
Author

@kairu-ms Could you provide assistance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants