Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] StorageAccounts - new feature - sasPolicy #3028

Merged
merged 3 commits into from
Mar 24, 2023
Merged

[Modules] StorageAccounts - new feature - sasPolicy #3028

merged 3 commits into from
Mar 24, 2023

Conversation

shawntmeyer
Copy link
Contributor

@shawntmeyer shawntmeyer commented Mar 20, 2023 •
edited
Loading

Description

Added support for SAS Policy Parameters. Fix for Issue #2997 with the help of @sdah0414.

Pipeline references

Storage - StorageAccounts

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@shawntmeyer shawntmeyer requested a review from a team as a code owner March 20, 2023 18:48
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Mar 20, 2023
@rahalan rahalan mentioned this pull request Mar 21, 2023
Closed
@rahalan rahalan linked an issue Mar 21, 2023 that may be closed by this pull request
[Feature Request]: StorageAccounts Module - Support for Sas Policy #3027
Closed
@eriqua eriqua changed the title [Module] StorageAccounts - new feature - sasPolicy [Modules] StorageAccounts - new feature - sasPolicy Mar 23, 2023
shawntmeyer
shawntmeyer commented Mar 23, 2023
View reviewed changes
Copy link
Contributor Author

@shawntmeyer shawntmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parameter removed.

@AlexanderSehr AlexanderSehr merged commit 268c449 into Azure:main Mar 24, 2023
@shawntmeyer shawntmeyer deleted the StorageAccounts-sasPolicySupport branch April 18, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@shawntmeyer shawntmeyer

Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: StorageAccounts Module - Support for Sas Policy
2 participants
@shawntmeyer @AlexanderSehr