feat: Move WASM to components.json #4969
Open
+5,632
−3,660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlisonB319
requested review from
lilypan26,
ShiqianTao,
AbelHu,
junjiezhang1997,
jason1028kr and
djsly
as code owners
| @@ -193,9 +193,6 @@ downloadCNI() { | |||
| retrycmd_get_tarball 120 5 "$downloadDir/${cniTgzTmp}" ${CNI_PLUGINS_URL} || exit $ERR_CNI_DOWNLOAD_TIMEOUT | |||
| } | |||
|
|
|||
| downloadContainerdWasmShims | |||
| echo " - containerd-wasm-shims ${CONTAINERD_WASM_VERSIONS}" >> ${VHD_LOGS_FILEPATH} | |||
|
|
|||
| echo "VHD will be built with containerd as the container runtime" | |||
| updateAptWithMicrosoftPkg | |||
| capture_benchmark "create_containerd_service_directory_download_shims_configure_runtime_and_network" | |||
There was a problem hiding this comment.
nit: would you mind removing the download_shims part out of the benchmark title and replacing it with and? The rest looks good to me!
| }, | ||
| { | ||
| "renovateTag": "<DO_NOT_UPDATE>", | ||
| "latestVersion": "0.8.0" |
There was a problem hiding this comment.
we also want 0.15.1 now as well right?
| # Install, download, update wasm must all be run from the same function call | ||
| # in order to ensure WASMSHIMPIDS persists correctly since in bash a new | ||
| # function call from install-dependnecies will create a new shell process. | ||
| installingContainerdWasmShims(){ |
There was a problem hiding this comment.
nit: installContainerdWasmShims?
| } | ||
|
|
||
| updateContainerdWasmShimsPermissions() { | ||
| containerd_wasm_filepath=${1} |
There was a problem hiding this comment.
nit: let's use local when defining local vars in general
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: