Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARO-12034 Fix CheckAccessV2 usage for MIWI dynamic validation #3946

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rajdeepc2792
Copy link
Collaborator

Which issue this PR addresses:

Fixes https://issues.redhat.com/browse/ARO-12034

What this PR does / why we need it:

After #3920 got merged, the MIWI cluster dynamic validation fails as the access token is mandatory to use checkAccessV2.
But since Platform Workload Identities are used via Federated Credentials or OIDC way, the access token for them can only be fetched after KubeAPI Server is up. So, for the fix, when validating Platform Workload Identity, we won't be using the access token and also won't be using the Group Expansion.

Related Thread:- https://redhat-external.slack.com/archives/C03F6AA3HDH/p1730225417576639

Test plan for issue:

[] Unit Test Cases
[] Local Cluster Creation
[] CI
[] E2E

Is there any documentation that needs to be updated for this PR?

Update the Customer Facing documentation for MIWI, such that the customer should only perform the role assignment directly on the platform workload identity and shouldn't be adding the identities to group for the role assignment.

How do you know this will function as expected in production?

Testing in local and canary.

@rajdeepc2792 rajdeepc2792 added work-in-progress chainsaw Pull requests or issues owned by Team Chainsaw labels Nov 7, 2024
Copy link
Contributor

@kimorris27 kimorris27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, for the fix, when validating Platform Workload Identity, we won't be using the access token and also won't be using the Group Expansion.

I'm a little confused. My reading of the new code is that changes are being made not to the platform identity validation but to the cluster MSI validation, and that the cluster MSI is no longer being validated. I find check access v2 confusing in general though. Could you help me understand it a bit better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chainsaw Pull requests or issues owned by Team Chainsaw work-in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants