Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Encryption At Host Dynamic Validation #3826

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SudoBrendan
Copy link
Collaborator

@SudoBrendan SudoBrendan commented Sep 9, 2024

Which issue this PR addresses:

Fixes https://issues.redhat.com/browse/ARO-3837

What this PR does / why we need it:

  • Frontend will now validate that Compute Encryption At Host is enabled on customer's subscription before installing clusters that want to use the feature - this will fix a Cluster Install Failure issue
  • In memory of Swetha. Thanks for your amazing contributions to our team, I'm glad we can finally get your work across the line with this one.

Test plan for issue:

  • Unit tests
  • I will perform a manual validation of this, but that will require some effort (a subscription without the feature enabled).

Is there any documentation that needs to be updated for this PR?

N/A fixes a bug

How do you know this will function as expected in production?

Unit tests and manual tests. Since this uses a new First Party Service Principal authorization (GET on Sub features), we should test this out pretty well for Canary as well before moving forward with it to other regions.

@SudoBrendan
Copy link
Collaborator Author

/azp run ci

@SudoBrendan
Copy link
Collaborator Author

/azp run e2e

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SudoBrendan
Copy link
Collaborator Author

Adding hold because apparently our FPSP permissions were flagged for being not in use for a substantial time, so we need to redo that effort and rollout the permissions before this can merge.

@SudoBrendan SudoBrendan added the hold Hold label Sep 9, 2024
@SudoBrendan SudoBrendan changed the title Encryption At Host Dynamic Validation [DO NOT MERGE] Encryption At Host Dynamic Validation Sep 9, 2024
@SudoBrendan SudoBrendan force-pushed the sudobrendan/ARO-3211-encryption-at-host-dyn-validation branch 3 times, most recently from b07dc2a to efbfa50 Compare September 10, 2024 01:15
- Frontend will now validate that Encryption At Host is enabled on customer's
  subscription before installing clusters
- In memory of Swetha. Thanks for your amazing contributions to our
  team, I'm glad we can finally get your work across the line with this one.

Co-authored-by: Swetha Chirumamilla <[email protected]>
@SudoBrendan SudoBrendan force-pushed the sudobrendan/ARO-3211-encryption-at-host-dyn-validation branch from efbfa50 to a1b1c09 Compare September 10, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant