Consume go otel audit lib #3767
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase pull request. |
#3766) and arosvc registries Updating checksum to sha256:dbf5304bd98cd51c72e4ae0ee8511d3bbcdbcb7e72e65e7d1495a50d7ac33b8d
* bump prettier + config * run prettier on portal * update to use native HTTP fetch * clean up some typescript lint problems * regen * fix * rebuild * send correct content type * regen
* Add --assign-platform-wi flag to az aro update * Fix nil pointer dereference when converting Identity structs on API * Restructure update command to make branching logic more clear * Remove duplicate test * Disallow passing in duplicate platform workload identities within the same create/update invocation * Ensure reported duplicate platform_workload_identities list doesn't itself contain duplicates
hive:bdf9d08a06 uses github.com/openshift/hive git commit bdf9d08a060abf558ca60e014123bf9278f58b4b.
…into InstrumentOtelAudit
| @@ -20,6 +20,7 @@ import ( | |||
| "github.com/Azure/ARO-RP/pkg/proxy" | |||
| "github.com/Azure/ARO-RP/pkg/util/encryption" | |||
| "github.com/Azure/ARO-RP/pkg/util/keyvault" | |||
| auditlog "github.com/Azure/ARO-RP/pkg/util/log/audit" | |||
There was a problem hiding this comment.
Question for me - why are we aliasing the name of the package?
| @@ -1603,3 +1611,6 @@ replace ( | |||
| go.mongodb.org/mongo-driver => go.mongodb.org/mongo-driver v1.9.4 | |||
| google.golang.org/grpc => google.golang.org/grpc v1.56.3 | |||
| ) | |||
|
|
|||
| // go-otel-audit pins | |||
There was a problem hiding this comment.
Please explain why this is necessary - it's clear that the replace directive is pinning :)
| @@ -515,7 +515,7 @@ func TestFixEtcd(t *testing.T) { | |||
| }) | |||
|
|
|||
| f, err := NewFrontend(ctx, | |||
| ti.audit, | |||
| ti.audit, ti.otelAudit, | |||
There was a problem hiding this comment.
Likely best in these cases to be consistent with where the newlines are
| auditMsg := msgs.Msg{Type: msgs.ControlPlane} | ||
| auditRec := audit.GetAuditRecord() | ||
|
|
||
| callerIpAddress, err := msgs.ParseAddr(strings.Split(r.RemoteAddr, ":")[0]) |
There was a problem hiding this comment.
Please handle strings.Split not finding a :
|
|
||
| callerIpAddress, err := msgs.ParseAddr(strings.Split(r.RemoteAddr, ":")[0]) | ||
| if err != nil { | ||
| log.Printf("Error parsing remote address: %s, error: %v", r.RemoteAddr, err) |
There was a problem hiding this comment.
If this is not recoverable, you need to return or exit the process.
|
Please rebase pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes
What this PR does / why we need it:
Test plan for issue:
Is there any documentation that needs to be updated for this PR?
How do you know this will function as expected in production?